Allow returning geometry by leg #7256
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ead of having one for the whole route
- Update HTTP API docs for route, match, and trip services - Update Node.js API docs for route, match, and trip methods - Update test error messages to include by_legs option 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Right now it is kind of a pain to get the geometry by leg. You can request the steps and accumulate it, but that is annoying if you are not interested in the instructions. With hindsight that wasn't the greatest API decision, alas better fix it late then never. In general it doesn't make sense to have it by route and by leg at the same time, so it seems appropriate to extend the
overviewoption for triggering the new behavior.This is still work-in-progress, I need to spend some time to make sure the flatbuffer stuff isn't broken by this and add tests.
Implementation
overview=by_legsparameter that will add the (unsimplified) geometry by leg.Tasklist