Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/multiple schemas #130

Conversation

lvlvllvlvllvlvl
Copy link
Collaborator

Abstract

Support switching specifications as per #21, and restore spec generation from the json schema

Action Taken

Caveats

  • The alpha and beta specs have been left as-is; it's not clear if they are used at all
  • The name mapping heuristic for Key suffixes is completely naive; it only checks that a matching column exists in the target spec, not that the source and target columns have compatible types
  • Similarly, the entire json schema could be validated against the stable spec, to notify us when a column is redefined, which may require a code change

@lvlvllvlvllvlvl lvlvllvlvllvlvl merged commit 581d475 into Project-Path-of-Exile-Wiki:dev Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant