compose map icons like the game #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the introduction of five new purple T17 maps in 3.24 the old approximation of how maps were composed from a base plate and a colorized sigil was insufficient. This change implements the relevant parts of the game UI shader for tinting UI elements like the map items, ignoring parts that are not used for these assets like saturation (always 1.0) and colour scaling (also always 1.0). For reference, see `PShad` in `Draw2D.hlsl`. The colour tint for the four different tier groups is obtained from the game renderer for maximum correctness. This also updates the defunct `atlas_icons` export to tint the sigils in the same way.
lvlvllvlvllvlvl
merged commit 2c82bf2
into
Project-Path-of-Exile-Wiki:dev
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Implemented map item tinting and composition like the game does with accurate coefficients.
Action Taken
With the introduction of five new purple T17 maps in 3.24 the old approximation of how maps were composed from a base plate and a colorized sigil was insufficient.
This change implements the relevant parts of the game UI shader for tinting UI elements like the map items, ignoring parts that are not used for these assets like saturation (always 1.0) and colour scaling (also always 1.0). For reference, see
PShadinDraw2D.hlsl.The colour tint for the four different tier groups is obtained from the game renderer for maximum correctness.
This also updates the defunct
atlas_iconsexport to tint the sigils in the same way.Caveats
The generated table spec has new fields from a local copy of a pending PR to dat-schema to add a new
Purple_DDSFilecolumn toMapSeries.FAO
n/a