Tolerate newlines in translation file #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lvlvllvlvllvlvl
merged commit b0330fd
into
Project-Path-of-Exile-Wiki:dev
1 check passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Abstract
Accept strings in the translation file that have a newline between the quotation marks.
Action Taken
This doesn't appear to affect any of the english-language text exported by pypoe, but as of the recent patch, some translations in other languages have line breaks in them, which was causing the exporter to crash.
Caveats
This appears to not be semantic as it preceded by a \n escape sequence, which is how newlines are encoded in these files, so the newline is discarded and no space is inserted, but this may turn out to be an incorrect assumption.