Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AccountsTab: Avoid deprecated method call #393

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

AccountsTab: Avoid deprecated method call #393

wants to merge 1 commit into from

Conversation

dontub
Copy link
Collaborator

@dontub dontub commented Jul 14, 2023

Passing true as $attributes in add() triggers a deprecated error and has no impact.

AccountsTab: Avoid deprecated method call
17b697e 
Passing `true` as `$attributes` in `add()` triggers a deprecated error
and has no impact.
@jensschuppe
Copy link
Collaborator

Possible this true was supposed to be the $required marker, as QuickForm methods are really weird evaluating their arguments, depending on values of the first argument (at least). I'm not sure, but for 'hidden' elements, this might be the case. @bjendres would you be able to find out what this true was supposed to do?

@jensschuppe jensschuppe requested a review from bjendres July 14, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjendres bjendres Awaiting requested review from bjendres

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dontub @jensschuppe