Remove some 'not defined' notices in importer code #399
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jensschuppe
requested changes
Sep 6, 2023
| @@ -168,11 +168,19 @@ function import_file( $file_path, $params ) | |||
|
|
|||
| // first: set the count | |||
| $params['total_tx_count'] = 0; | |||
| foreach ($config->payments as $payment_spec) { | |||
| $params['total_tx_count'] += $this->xpath->query($payment_spec->path)->length; | |||
| if (!empty($config->payments)) { | |||
There was a problem hiding this comment.
As empty() doesn't check for the statement being an array/iterable, I suppose $config->payments is guaranteed to always be an array if it's not empty?
| @@ -315,7 +327,12 @@ protected function filterMatches($payment_node, $filter) { | |||
| */ | |||
| protected function import_payment($payment_spec, $payment_node, $stmt_data, $index, $params) { | |||
| $config = $this->_plugin_config; | |||
| $progress = ((float)$index / (float) $params['total_tx_count']); | |||
| $total_tx_count = (float) $params['total_tx_count'] ?? 1.0; | |||
| if ($total_tx_count) { | |||
There was a problem hiding this comment.
Is this condition necessary now that there's a null-coalescing default of 1.0 and an implicit default of 0 due to the type cast to float?
There was a problem hiding this comment.
This might also use some brackets, too. If I get that right, he type cast will always cause a non-NULL value be given to the null-coalescing operator, making it rather useless here. Maybe this helps.
| $progress = ((float)$index / (float) $params['total_tx_count']); | ||
| $total_tx_count = (float) $params['total_tx_count'] ?? 1.0; | ||
| if ($total_tx_count) { | ||
| $progress = ((float)$index / ((float) $params['total_tx_count'] ?? 0.0)); |
There was a problem hiding this comment.
And if so, this should read $total_tx_count instead of $params['total_tx_count'], right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.