fix #409: add option to preserve original receive_date #413
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR is still waiting to be merged. |
jensschuppe
requested changes
Nov 19, 2024
| @@ -44,6 +44,7 @@ function __construct($config_name) { | |||
| if (!isset($config->default_financial_type_id)) $config->default_financial_type_id = 1; | |||
| if (!isset($config->createnew_value_propagation)) $config->createnew_value_propagation = array(); | |||
| if (!isset($config->manual_default_financial_type_id)) $config->manual_default_financial_type_id = NULL; | |||
| if (!isset($config->preserve_receive_date)) $config->preserve_receive_date = 0; // Set to 1 to preserve the receive_date (instead of overwriting it with the booking_date). See issue #409. | |||
There was a problem hiding this comment.
I see this follows existing formatting, but conditions (if) without brackets ({…}) should really be avoided. Also, the comment should be put above the condition.
There was a problem hiding this comment.
Suggested change
| if (!isset($config->preserve_receive_date)) $config->preserve_receive_date = 0; // Set to 1 to preserve the receive_date (instead of overwriting it with the booking_date). See issue #409. | |
| // Set to 1/TRUE to preserve the receive_date (instead of overwriting it with the booking_date). See issue #409. | |
| $config->preserve_receive_date = (bool) ($config->preserve_receive_date ?? FALSE); |
There was a problem hiding this comment.
Thanks! I agree with the changes, even though I think it doesn't necessarily contribute to the readability of the code to suddenly deviate from the scheme in the nth repeated line.
| @@ -53,6 +53,7 @@ function __construct($config_name) { | |||
| if (!isset($config->date_penalty)) $config->date_penalty = 1.0; | |||
| if (!isset($config->payment_instrument_penalty)) $config->payment_instrument_penalty = 0.0; | |||
| if (!isset($config->financial_type_penalty)) $config->financial_type_penalty = 0.0; | |||
| if (!isset($config->preserve_receive_date)) $config->preserve_receive_date = 0; // Set to 1 to preserve the receive_date (instead of overwriting it with the booking_date). See issue #409. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a configuration option called
preserve_receive_datewhich when set totrueprevents the originalreceive_dateof the contribution from being overwritten.The configuration can be set in the Default Options Matcher and in the Contribution Matcher.
Fix #409