Skip to content

Commit

Permalink
test: 미흡한 테스트 코드 추가 작성
Browse files Browse the repository at this point in the history
  • Loading branch information
YehyeokBang committed Jan 29, 2024
1 parent 545101b commit 5510300
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 12 deletions.
24 changes: 24 additions & 0 deletions app/report/services/report_service_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -258,6 +258,30 @@ func TestCalculateScores_HalfGood(t *testing.T) {
assert.Equal(t, "57.50", result)
}

func TestCalculateScores_AllGoodDiffScore(t *testing.T) {
// Set up test data
testResult := []int{1, 1, 1, 1, 1, 1}
testScores := []float64{99.9, 89.9, 79.9, 69.9, 59.9, 49.9}

// Execute method under test
result := services.CalculateScores(testResult, testScores)

// Assert result
assert.Equal(t, "93.83", result)
}

func TestCalculateScores_AllBadSameScore(t *testing.T) {
// Set up test data
testResult := []int{0, 0, 0, 0, 0, 0}
testScores := []float64{99.9, 89.9, 79.9, 69.9, 59.9, 49.9}

// Execute method under test
result := services.CalculateScores(testResult, testScores)

// Assert result
assert.Equal(t, "24.50", result)
}

func TestCalculateScores_AllGood(t *testing.T) {
// Set up test data
testResult := []int{1, 1, 1, 1, 1, 1}
Expand Down
8 changes: 0 additions & 8 deletions app/user/controllers/user_controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -152,14 +152,6 @@ func (controller *UserController) UpdateUserInfo(c *gin.Context) {
return
}

if err := input.Validate(); err != nil {
c.JSON(400, global.Response{
Status: 400,
Message: err.Error(),
})
return
}

user, err := controller.UserService.UpdateUserInfo(c, input)
if err != nil {
c.JSON(400, global.Response{
Expand Down
5 changes: 1 addition & 4 deletions app/user/services/user_service.go
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,7 @@ func (service *UserService) Login(input types.RequestCreateUser) (types.Response
user.FcmToken = input.FcmToken
updatedUser, _ := service.UserRepository.Update(user)

token, err := service.generateToken(updatedUser.ID)
if err != nil {
return types.ResponseToken{}, err
}
token, _ := service.generateToken(updatedUser.ID)

return types.ResponseToken{Token: token}, nil
}
Expand Down

0 comments on commit 5510300

Please sign in to comment.