lock down content-type headers in test cases

ProjectEvergreen · Aug 20, 2023 · 1892226 · 1892226
1 parent 887efe7
commit 1892226
Show file tree

Hide file tree

Showing 20 changed files with 38 additions and 37 deletions.
diff --git a/packages/cli/src/lib/resource-utils.js b/packages/cli/src/lib/resource-utils.js
@@ -174,6 +174,7 @@ function isLocalLink(url = '') {
 function transformKoaRequestIntoStandardRequest(url, request) {
   const { body, method, header } = request;
 
+  // https://developer.mozilla.org/en-US/docs/Web/API/Request/Request#parameters
   return new Request(url, {
     body: ['GET', 'HEAD'].includes(method.toUpperCase())
       ? null

diff --git a/packages/cli/test/cases/develop.default.hud-disabled/develop.default.hud-disabled.spec.js b/packages/cli/test/cases/develop.default.hud-disabled/develop.default.hud-disabled.spec.js
@@ -86,7 +86,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/develop.default.hud/develop.default.hud.spec.js b/packages/cli/test/cases/develop.default.hud/develop.default.hud.spec.js
@@ -86,7 +86,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/develop.plugins.context/develop.plugins.context.spec.js b/packages/cli/test/cases/develop.plugins.context/develop.plugins.context.spec.js
@@ -141,7 +141,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/css');
+        expect(response.headers['content-type']).to.equal('text/css');
         done();
       });
 
@@ -179,7 +179,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 

diff --git a/packages/cli/test/cases/develop.spa/develop.spa.spec.js b/packages/cli/test/cases/develop.spa/develop.spa.spec.js
@@ -96,7 +96,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -135,7 +135,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -174,7 +174,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -211,7 +211,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/css');
+        expect(response.headers['content-type']).to.equal('text/css');
         done();
       });
 
@@ -251,7 +251,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/css');
+        expect(response.headers['content-type']).to.equal('text/css');
         done();
       });
 

diff --git a/packages/cli/test/cases/develop.ssr/develop.ssr.spec.js b/packages/cli/test/cases/develop.ssr/develop.ssr.spec.js
@@ -166,7 +166,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/serve.config.static-router/serve.config.static-router.spec.js b/packages/cli/test/cases/serve.config.static-router/serve.config.static-router.spec.js
@@ -95,7 +95,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/...ses/serve.default.ssr-prerender-api-hybrid/serve.default.ssr-prerender-api-hybrid.spec.js b/...ses/serve.default.ssr-prerender-api-hybrid/serve.default.ssr-prerender-api-hybrid.spec.js
@@ -96,7 +96,7 @@ describe('Serve Greenwood With: ', function() {
         });
 
         it('should return the correct content type', function(done) {
-          expect(response.headers['content-type']).to.contain('text/html');
+          expect(response.headers['content-type']).to.equal('text/html');
           done();
         });
 
@@ -162,7 +162,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json');
         done();
       });
 

diff --git a/packages/cli/test/cases/serve.default.ssr-prerender/serve.default.ssr-prerender.spec.js b/packages/cli/test/cases/serve.default.ssr-prerender/serve.default.ssr-prerender.spec.js
@@ -93,7 +93,7 @@ describe('Serve Greenwood With: ', function() {
         });
 
         it('should return the correct content type', function(done) {
-          expect(response.headers['content-type']).to.contain('text/html');
+          expect(response.headers['content-type']).to.equal('text/html');
           done();
         });
 

diff --git a/...es/cli/test/cases/serve.default.ssr-static-export/serve.default.ssr-static-export.spec.js b/...es/cli/test/cases/serve.default.ssr-static-export/serve.default.ssr-static-export.spec.js
@@ -170,7 +170,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/serve.default.ssr/serve.default.ssr.spec.js b/packages/cli/test/cases/serve.default.ssr/serve.default.ssr.spec.js
@@ -149,7 +149,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/serve.default/serve.default.spec.js b/packages/cli/test/cases/serve.default/serve.default.spec.js
@@ -98,7 +98,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json; charset=utf-8');
         done();
       });
 
@@ -133,7 +133,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json; charset=utf-8');
         done();
       });
 
@@ -310,7 +310,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain(ext);
+        expect(response.headers['content-type']).to.equal(`video/${ext}`);
         done();
       });
 
@@ -349,7 +349,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('audio/mpeg');
+        expect(response.headers['content-type']).to.equal('audio/mpeg');
         done();
       });
 
@@ -388,7 +388,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json');
         done();
       });
 
@@ -422,7 +422,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json');
         done();
       });
 

diff --git a/packages/cli/test/cases/serve.spa/serve.spa.spec.js b/packages/cli/test/cases/serve.spa/serve.spa.spec.js
@@ -92,7 +92,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -130,7 +130,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -169,7 +169,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/cli/test/cases/theme-pack/theme-pack.develop.spec.js b/packages/cli/test/cases/theme-pack/theme-pack.develop.spec.js
@@ -141,7 +141,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/css');
+        expect(response.headers['content-type']).to.equal('text/css');
         done();
       });
 
@@ -179,7 +179,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 

diff --git a/packages/init/test/cases/develop.default/develop.default.spec.js b/packages/init/test/cases/develop.default/develop.default.spec.js
@@ -113,7 +113,7 @@ xdescribe('Scaffold Greenwood and Run Develop command: ', function() {
           });
 
           it('should return the correct content type', function(done) {
-            expect(response.headers['content-type']).to.contain('text/html');
+            expect(response.headers['content-type']).to.equal('text/html');
             done();
           });
 

diff --git a/packages/plugin-graphql/test/cases/develop.default/develop.default.spec.js b/packages/plugin-graphql/test/cases/develop.default/develop.default.spec.js
@@ -89,7 +89,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 
@@ -134,7 +134,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 
@@ -170,7 +170,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 

diff --git a/packages/plugin-graphql/test/cases/qraphql-server/graphql-server.spec.js b/packages/plugin-graphql/test/cases/qraphql-server/graphql-server.spec.js
@@ -81,7 +81,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
     });
@@ -125,7 +125,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('application/json');
+        expect(response.headers['content-type']).to.equal('application/json; charset=utf-8');
         done();
       });
 

diff --git a/packages/plugin-import-css/test/cases/develop.default/develop.default.spec.js b/packages/plugin-import-css/test/cases/develop.default/develop.default.spec.js
@@ -89,7 +89,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 
@@ -132,7 +132,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
 

diff --git a/packages/plugin-renderer-lit/test/cases/serve.default/serve.default.spec.js b/packages/plugin-renderer-lit/test/cases/serve.default/serve.default.spec.js
@@ -183,7 +183,7 @@ describe('Serve Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/html');
+        expect(response.headers['content-type']).to.equal('text/html');
         done();
       });
 

diff --git a/packages/plugin-typescript/test/cases/develop.default/develop.default.spec.js b/packages/plugin-typescript/test/cases/develop.default/develop.default.spec.js
@@ -82,7 +82,7 @@ describe('Develop Greenwood With: ', function() {
       });
 
       it('should return the correct content type', function(done) {
-        expect(response.headers['content-type']).to.contain('text/javascript');
+        expect(response.headers['content-type']).to.equal('text/javascript');
         done();
       });
-Original file line number
+Diff line change
@@ Expand Up / @@ -86,7 +86,7 @@ describe('Develop Greenwood With: ', function() { @@
           });
           it('should return the correct content type', function(done) {
-            expect(response.headers['content-type']).to.contain('text/html');
+            expect(response.headers['content-type']).to.equal('text/html');
             done();
           });
@@ Expand Down @@