fix attribute selector syntax used in test cases

ProjectEvergreen · Nov 1, 2024 · 948158a · 948158a
1 parent c64e720
commit 948158a
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/packages/plugin-renderer-lit/src/index.js b/packages/plugin-renderer-lit/src/index.js
@@ -25,8 +25,8 @@ class LitHydrationResource extends ResourceInterface {
     const hydrationSupportScriptPath = '/node_modules/@lit-labs/ssr-client/lit-element-hydrate-support.js';
     let body = await response.text();
 
-    // this needs to come first before any userland code
-    // but before any import maps
+    // this needs to come first before any userland code, but before any import maps
+    // https://github.com/ProjectEvergreen/greenwood/pull/1289
     if (isDevelopment) {
       // quick way to find the ending position of the importmap <script> tag
       // and append the hydration support <script> right after it

diff --git a/packages/plugin-renderer-lit/test/cases/develop.default/develop.default.spec.js b/packages/plugin-renderer-lit/test/cases/develop.default/develop.default.spec.js
@@ -213,7 +213,7 @@ describe('Develop Greenwood With: ', function() {
 
       it('should have the expected lit hydration script _after_ any importmaps in the <head>', function() {
         // make sure this does NOT come before an importmap
-        const scripts = Array.from(dom.window.document.querySelectorAll('script[src*="lit-element-hydrate-support"] + script[type="importmap"'));
+        const scripts = Array.from(dom.window.document.querySelectorAll('script[src*="lit-element-hydrate-support"] + script[type="importmap"]'));
 
         expect(scripts.length).to.equal(0);
       });

diff --git a/test/smoke-test.js b/test/smoke-test.js
@@ -108,7 +108,7 @@ function commonIndexSpecs(dom, html, label) {
       });
 
       it('should not have any module based <script> tags that come _before_ any importmaps in the <head>', function() {
-        const scripts = Array.from(dom.window.document.querySelectorAll('script[type="module"] + script[type*="importmap"'));
+        const scripts = Array.from(dom.window.document.querySelectorAll('script[type="module"] + script[type*="importmap"]'));
 
         expect(scripts.length).to.equal(0);
       });