Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

data client not working on production builds (when not using prerender option) #1354

Closed
thescientist13 opened this issue Dec 21, 2024 · 0 comments · Fixed by #1358
Closed
Assignees
Labels
alpha.2 bug Something isn't working CLI Content as Data documentation Greenwood specific docs v0.31.0
Milestone

Comments

@thescientist13
Copy link
Member

Type of Change

Bug

Summary

While working on this project realized that there was a significant oversight in how the data client would work. It technically won't work as is without prerender enabled for a production build, since without prerendering, the custom JSON files per query will not be generated, leading to 404s in a production build
image

Details

It seems for now we can get away with making a non-prerender fallback for the data client, where if prerendering was not used, we can just fetch graph.json and do the filtering client side.

@thescientist13 thescientist13 added bug Something isn't working documentation Greenwood specific docs CLI Content as Data labels Dec 21, 2024
@thescientist13 thescientist13 added this to the 1.0 milestone Dec 21, 2024
@thescientist13 thescientist13 self-assigned this Dec 21, 2024
@thescientist13 thescientist13 changed the title data client not working on production builds (when not using prerender option) data client not working on production builds when not using prerender option Dec 22, 2024
@thescientist13 thescientist13 changed the title data client not working on production builds when not using prerender option data client not working on production builds (when not using prerender option) Dec 22, 2024
@thescientist13 thescientist13 moved this from 🔖 Ready to 🏗 In progress in [Greenwood] Phase 10 - Ecosystem Compat Dec 22, 2024
@thescientist13 thescientist13 moved this from 🏗 In progress to 👀 In review in [Greenwood] Phase 10 - Ecosystem Compat Dec 22, 2024
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in [Greenwood] Phase 10 - Ecosystem Compat Dec 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
alpha.2 bug Something isn't working CLI Content as Data documentation Greenwood specific docs v0.31.0
Projects
1 participant