Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/clarify recommendations for using data client #154

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Dec 21, 2024

Related Issue

ProjectEvergreen/greenwood#1354

Summary of Changes

  1. Completely missed documenting the expectations around data client and prerender 🤦‍♂️ - it's actually not technically required, just recommended

TODO

  1. re-document to callout options with and without prerender option

@thescientist13 thescientist13 added the docs Greenwood specific content like docs and guides label Dec 21, 2024
Copy link

netlify bot commented Dec 21, 2024

Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit f1054be
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67981678ad04230009a71b8f
😎 Deploy Preview https://deploy-preview-154--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 changed the title document prerender callout for data client docs/document prerender callout for data client Dec 21, 2024
@thescientist13 thescientist13 marked this pull request as draft December 21, 2024 18:08
@thescientist13 thescientist13 changed the title docs/document prerender callout for data client docs/clarify requirements for using data client Jan 25, 2025
@thescientist13 thescientist13 changed the title docs/clarify requirements for using data client docs/clarify recommendations for using data client Jan 25, 2025
@thescientist13 thescientist13 marked this pull request as ready for review January 25, 2025 00:23
@thescientist13 thescientist13 force-pushed the docs/prerender-is-required-for-active-content branch from bc8b955 to f1054be Compare January 27, 2025 23:27
@thescientist13 thescientist13 merged commit e446934 into main Jan 27, 2025
5 checks passed
@thescientist13 thescientist13 deleted the docs/prerender-is-required-for-active-content branch January 27, 2025 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Greenwood specific content like docs and guides release/v0.31.0
Projects
Development

Successfully merging this pull request may close these issues.

1 participant