Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement/issue 1312 ESM-only PostCSS configuration file #1332

Merged

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Nov 30, 2024

Related Issue

resolves #1312

Summary of Changes

  1. Only check for an ESM based configuration file
  2. Update PostCSS related dependencies
  3. Update plugin README

Breaking change will require renaming postcss.config.mjs -> postcss.config.js

Documentation

  1. Create issue to update PostCSS website docs - update PostCSS docs to reflect ESM-only configuration www.greenwoodjs.dev#145

TODO

  1. Sanity check, since in retrospect, seems like we never needed this, since we programmatically loaded the configuration file ourselves? - [DEMO] ESM-only PostCSS config AnalogStudiosRI/www.blissri.com#54
    • works just fine as is lol 😅
  2. restore custom configuration docs - https://github.com/ProjectEvergreen/greenwood/pull/1332/files#r1864679805

@thescientist13 thescientist13 added documentation Greenwood specific docs Plugins Greenwood Plugins feature New feature or request labels Nov 30, 2024
@thescientist13 thescientist13 marked this pull request as ready for review November 30, 2024 23:20
@thescientist13 thescientist13 changed the title feature/issue 1312 ESM-only PostCSS config feature/issue 1312 ESM-only PostCSS configuration file Nov 30, 2024
@@ -52,32 +52,6 @@ export default {

## Options

### Configuration

To use your own PostCSS configuration, you'll need to create _two (2)_ config files in the root of your project, by which you can provide your own custom plugins / settings that you've installed.

This comment was marked as resolved.

@lschierer
Copy link
Contributor

I think the difference is that https://github.com/postcss/postcss-load-config now supports a zillion different formats but your plugin documentation never got updated when it did, as it points at a really old issue :-)

@thescientist13
Copy link
Member Author

Yeah, I think this was just an implementation error on our part since we don't actually rely on PostCSS to find the configuration file, we feed the options directly to PostCSS ourselves so in retrospect the .cjs variant was never needed probably 🤦‍♂️ 😅

@thescientist13 thescientist13 force-pushed the enhancement/issue-1312-esm-only-postcss-configuration branch from 37ea382 to e2afec6 Compare December 13, 2024 20:30
@thescientist13 thescientist13 added enhancement Improve something existing (e.g. no docs, new APIs, etc) and removed feature New feature or request labels Dec 13, 2024
@thescientist13 thescientist13 changed the title feature/issue 1312 ESM-only PostCSS configuration file enhancement/issue 1312 ESM-only PostCSS configuration file Dec 13, 2024
@thescientist13 thescientist13 merged commit 93ef3db into master Dec 13, 2024
8 checks passed
@thescientist13 thescientist13 deleted the enhancement/issue-1312-esm-only-postcss-configuration branch December 13, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking documentation Greenwood specific docs enhancement Improve something existing (e.g. no docs, new APIs, etc) Plugins Greenwood Plugins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESM only configuration for PostCSS plugin
2 participants