Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore/issue 43 linting for markdown and JSON #102

Merged
merged 9 commits into from
Oct 4, 2024
Merged

chore/issue 43 linting for markdown and JSON #102

merged 9 commits into from
Oct 4, 2024

Conversation

thescientist13
Copy link
Member

@thescientist13 thescientist13 commented Oct 4, 2024 •
edited
Loading

Related Issue

resolves #42 and #43

https://eslint.org/blog/2024/10/eslint-json-markdown-support/

Summary of Changes

  1. Add new @eslint/markdown plugin
  2. Add new @eslint/json plugin
  3. Adopted ESLint recommended rules
  4. Helped find and fixed a couple issues in our markdown content 🙌 😮‍💨

TODO

  1. Need to ignore support, which has landed, but just hasn't been published yet, which should fix the build failure
  2. Clean up / validate sample - https://github.com/ProjectEvergreen/www.greenwoodjs.dev/pull/102/files#r1787067798
  3. rebase / merge after all open PRs are merged

@thescientist13 thescientist13 added chore project maintenance related tasks enhancement New feature or request labels Oct 4, 2024
@netlify Netlify
Copy link

netlify bot commented Oct 4, 2024 •
edited
Loading

✅ Deploy Preview for super-tapioca-5987ce ready!

Name Link
🔨 Latest commit
🔍 Latest deploy log https://app.netlify.com/sites/super-tapioca-5987ce/deploys/67006931b153102fd23f61a1
😎 Deploy Preview https://deploy-preview-102--super-tapioca-5987ce.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@thescientist13 thescientist13 added content Non Greenwood specific content like home page copy text, blog posts, etc and removed enhancement New feature or request labels Oct 4, 2024
thescientist13
thescientist13 commented Oct 4, 2024
View reviewed changes
CONTRIBUTING.md Outdated
@@ -121,6 +122,7 @@ For interactive components that would require client side interactivity, like ev
```js
import sheet from "./card.css" with { type: "css" };

const hello = world();
Copy link
Member Author

@thescientist13 thescientist13 Oct 4, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! this was just a test, need to remove this lol

interestingly, this example doesn't actually seem to trigger an error though? It's ripped right from the README though... 🤔

@thescientist13 thescientist13 changed the title linting for markdown and JSON chore/linting for markdown and JSON Oct 4, 2024
@thescientist13 thescientist13 changed the title chore/linting for markdown and JSON chore/issue 43 linting for markdown and JSON Oct 4, 2024
@thescientist13 thescientist13 force-pushed the chore/issue-43-eslint-markdown-json-linting branch from 32983cb to 361c348 Compare October 4, 2024 22:14
@thescientist13 thescientist13 merged commit ff1040e into main Oct 4, 2024
1 of 5 checks passed
@thescientist13 thescientist13 deleted the chore/issue-43-eslint-markdown-json-linting branch October 4, 2024 22:19
@thescientist13 thescientist13 mentioned this pull request Oct 6, 2024
Closed
@thescientist13 thescientist13 linked an issue Oct 6, 2024 that may be closed by this pull request
clean up style specific rules from ESLint configuration #42
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
chore project maintenance related tasks content Non Greenwood specific content like home page copy text, blog posts, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

clean up style specific rules from ESLint configuration
1 participant
@thescientist13