Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shape Utility Classes #11

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Shape Utility Classes #11

wants to merge 5 commits into from

Conversation

Simplicitee
Copy link
Member

@Simplicitee Simplicitee commented Jul 5, 2020 •
edited
Loading

Changes

✔️ Additions

  • Adds variety of 2D and 3D shape classes
  • Adds ShapeUtil class for shape-supporting functions
  • Adds alternate direction method to VectorUtil
  • Adds Plane utility class for describing a plane in space
  • Adds increment and decrement methods to Angle class

Checklist

  • I have tested my changes to the best of my abilities.
  • I have linked to any related GitHub Issues or Trello cards.
  • I have made sure my code is clean, well documented, and matches the pre-existing style of the codebase.
  • I understand that my pull request will only be merged after it is reviewed by maintainers and any requested changes are made.

@Simplicitee
shapes!
bec7974 
* Added variety of 2D and 3D shape classes
* Added ShapeUtil class for shape-supporting functions
* Added alternate direction method to VectorUtil
* Added Plane utility class for describing a plane in space
@Simplicitee
some additions and changes
605d66c
@ChristopherWMM
Copy link
Member

Where's the rest of the documentation? 😐

v-h-gn
v-h-gn reviewed Jul 10, 2020
View reviewed changes
Copy link
Member

@v-h-gn v-h-gn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe adding a little more documentation on the shape constructors specifying how they are going to look when constructed, what each of the variables mean, and how they affect the aforementioned look of the shapes.

@v-h-gn v-h-gn added this to the Complete Utilities milestone Aug 18, 2020
@v-h-gn v-h-gn linked an issue Aug 18, 2020 that may be closed by this pull request
create Shapes Utilities #14
Open
@Simplicitee Simplicitee requested a review from v-h-gn November 3, 2020 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristopherWMM ChristopherWMM Awaiting requested review from ChristopherWMM

@v-h-gn v-h-gn Awaiting requested review from v-h-gn

At least 2 approving reviews are required to merge this pull request.

Assignees

@Simplicitee Simplicitee

Labels
None yet
Projects
None yet
Milestone
Complete Utilities
Development

Successfully merging this pull request may close these issues.

create Shapes Utilities
3 participants
@Simplicitee @ChristopherWMM @v-h-gn