Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERC20 preapproved conduit solady: flip conduit allowance value for permit() #22

Merged
merged 5 commits into from
Nov 30, 2023
Merged

ERC20 preapproved conduit solady: flip conduit allowance value for permit() #22

merged 5 commits into from
Nov 30, 2023

Conversation

ryanio
Copy link
Contributor

@ryanio ryanio commented Nov 29, 2023 •
edited
Loading

No description provided.

@ryanio ryanio marked this pull request as draft November 29, 2023 23:10
@0age
Copy link
Contributor

0age commented Nov 29, 2023

nice; we could add this branchless one-liner on the approve flows / _spendAllowance / etc. too!

@ryanio ryanio marked this pull request as ready for review November 30, 2023 19:37
@0age 0age merged commit 1cc68ee into main Nov 30, 2023
4 checks passed
@0age 0age deleted the ryan/erc20-preapproved-conduit-solady-permit branch November 30, 2023 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0age 0age 0age approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanio @0age