Adapt to newer version of Watchy library and use newer features from it #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 23, 2024 20:03
It's Shanghai, not New York. Signed-off-by: Oleg Girko <[email protected]>
Now latitude and longitude can be used instead of city ID to retrieve weather information. OpenWeaterMap API URL has been changed accordingly. Also, locations of fields in watchySettings changed, so using explicit field names to initialise them. Signed-off-by: Oleg Girko <[email protected]>
This change removes calculations of sunrise and sunset time in favour of getting this information from weather data. This makes specifying exact latitude and longitude unnecessary: it's enough to have OpenWeatherMap city ID. As a nice side effect, this makes specifying timezone unnecessary as well, because weather data contains current timezone information, and Watchy::getWeatherData() sets timezone automatically. Signed-off-by: Oleg Girko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes this watchface compile and work with the current version of Watchy library.
Also, it removes calculating sunrise and sunset times and specifying coordinates explicitly in favour of using this information from OpenWeatherMap data.