Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

install docker-compose #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

install docker-compose #1

wants to merge 2 commits into from

Conversation

joliveros
Copy link

Hi All,

I'm looking to add docker-compose to the image in order to able to stand-up a project in order to run tests.

Thanks!

on-the-edge-4-me
on-the-edge-4-me reviewed Mar 1, 2021
View reviewed changes
Copy link

@on-the-edge-4-me on-the-edge-4-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. However, any reason you don't just add it to the other pip install command on line 38?

@joliveros
install docker-compose
cef6796 
Signed-off-by: Jose Oliveros <[email protected]>
@joliveros joliveros force-pushed the add-docker-compose branch from 4f3315d to cef6796 Compare March 1, 2021 23:05
@joliveros
Copy link
Author

Makes sense @on-the-edge-4-me ! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@on-the-edge-4-me on-the-edge-4-me on-the-edge-4-me left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joliveros @on-the-edge-4-me