Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI simple-tests: separate github action job for qRHL #713

Merged
merged 1 commit into from
Oct 31, 2023

Conversation

hendriktews
Copy link
Collaborator

Separate qRHL tests in ci/simple-tests from Coq tests such that they can run in a separate action. Before, the qRHL test was running twice, as part of simple-tests and additionally in test-indent.

Separate qRHL tests in ci/simple-tests from Coq tests such that they
can run in a separate action. Before, the qRHL test was running twice,
as part of simple-tests and additionally in test-indent.
@hendriktews
Copy link
Collaborator Author

Hi @dominique-unruh, is this PR fine with you?

In your qRHL test you write, you would like to check keypress translations. Can you give an example?

@dominique-unruh
Copy link
Contributor

@hendriktews

Hi @dominique-unruh, is this PR fine with you?

Yes.

In your qRHL test you write, you would like to check keypress translations. Can you give an example?

For example, I might want to check that, if I press the sequence *\subC, the buffer contains *⇩C afterwards. Currently, the test only checks whether the input method loads without errors, but not whether it does anything.

@monnier
Copy link
Contributor

monnier commented Oct 31, 2023 via email

@dominique-unruh
Copy link
Contributor

You should be able to cobble something up using unread-command-event, but it's messy.

If it's complicated, maybe best to leave those things untested instead.
If it's brittle, we might end up spending time fixing or debugging the tests down the line.

@hendriktews
Copy link
Collaborator Author

merging now, continuing the discussion later

@hendriktews hendriktews merged commit 0dd686e into ProofGeneral:master Oct 31, 2023
101 checks passed
@hendriktews
Copy link
Collaborator Author

I ended up with

  ;; To simulate typing, we put the keys into `unread-command-events'.
  ;; To process them normally, we enter a recursive edit. To abort the
  ;; recursive edit, we add \C-\M-c, the binding of
  ;; `exit-recursive-edit' to the simulated keys.
  (setq unread-command-events (listify-key-sequence "*\\subC\C-\M-c"))
  (recursive-edit)
  (should (equal "*⇩C" (buffer-substring 1 (point))))

which seems to run relatively stable, see PR #714

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants