Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reorder setParameters checks to fix mobile and fixed_line rules being interpreted as countries #242

Merged
merged 2 commits into from
Jan 15, 2024
Merged

Reorder setParameters checks to fix mobile and fixed_line rules being interpreted as countries #242

merged 2 commits into from
Jan 15, 2024

Conversation

mwnciau
Copy link
Contributor

@mwnciau mwnciau commented Jan 11, 2024 •
edited
Loading

Fixes #241

@Propaganistas
Copy link
Owner

Thanks. Highly unintended indeed. Could you add a test for this please? Happy to merge afterwards.

@mwnciau
Copy link
Contributor Author

mwnciau commented Jan 15, 2024

Done

@Propaganistas Propaganistas merged commit 57ec1db into Propaganistas:master Jan 15, 2024
14 checks passed
@Propaganistas
Copy link
Owner

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"mobile" parameter no longer working in 5.1.0 when one of the data fields is "mobile"
2 participants
@mwnciau @Propaganistas