-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update self.caller and self.signer documentation #288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @craigjson
I think the motivating example is a good way to introduce this command.
Do you think developers will copy and paste this example into their projects?
Do you have additional snarkvm CLI commands that you ran to test the functionality?
I expect the feature parity between Leo and Aleo Instructions to be resolved this week. |
A developer can copy and paste this example, however I'd say it's fairly academic and limited in it's usability for a production program. It reminds me of an example a professor would use to show how OOP Inheritance works. I added some steps to create a project and run this on the CLI to generate the output that is provided |
Hi @craigjson can you see my latest PR against this one #291 |
…program-interop-examples
commit program interoperability examples
merged |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Makes the following updates to the
.aleo
documentationself.caller
to referenceself.signer
self.caller
explaining the new featureself.signer
andself.caller
One question, with this update, there will be inconsistency between the
Leo
andAleo
documentation. Namely, that because Leo has not yet implemented the newself.caller
, the documentation that refers to it https://developer.aleo.org/leo/language#selfcaller will actually be talking aboutself.signer
in Aleo instructions. I worry this may cause some confusion. We could remove this section in the Leo docs for now, curious to your thoughts @collinc97Part of: https://github.com/AleoHQ/snarkVM/pull/2020