-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
加入 log level #272
加入 log level #272
Conversation
加入色彩感覺很棒,不過他可以是可選的嗎?總覺得如果把色彩寫到在 /var/log 的紀錄檔裡面之後在用工具來分析會有點令人不安。 但是對於開發時直接用cli 執行來說應該是有幫助。 |
有沒有考慮用開源專案?像是 sirupsen/logrus 或 rs/zerolog 這些簡易的 Logger 模組? |
這部分在做輸出的時候有判斷 |
目前的想法是先銜接當前的程式碼,不要做太大改動。 |
Codecov Report
@@ Coverage Diff @@
## development #272 +/- ##
===============================================
+ Coverage 44.49% 45.23% +0.74%
===============================================
Files 29 29
Lines 1661 1691 +30
===============================================
+ Hits 739 765 +26
- Misses 819 821 +2
- Partials 103 105 +2
Continue to review full report at Codecov.
|
@PichuChen 請問這個 PR 有什麼需要修改的地方嗎? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
👏 解決掉的 issue / Resolved Issues
📝 相關的 issue / Related Issues
⛏ 變更內容 / Details of Changes
route_token.go
不使用logger
的錯誤