Update Oracle Storage Layout #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shayanb
reviewed
May 11, 2024
src/PufferOracleV2.sol
Outdated
| @@ -58,6 +58,7 @@ contract PufferOracleV2 is IPufferOracleV2, AccessManaged { | |||
| _totalNumberOfValidators = 927122; // Oracle will be updated with the correct value | |||
| _epochNumber = 268828; // Oracle will be updated with the correct value | |||
| _setMintPrice(0.01 ether); | |||
Update Oracle Storage Layout
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
…nto bugfix/oracle
shayanb
reviewed
May 12, 2024
src/PufferOracleV2.sol
Outdated
| @@ -57,15 +57,16 @@ contract PufferOracleV2 is IPufferOracleV2, AccessManaged { | |||
| PUFFER_VAULT = vault; | |||
| _totalNumberOfValidators = 927122; // Oracle will be updated with the correct value | |||
| _epochNumber = 268828; // Oracle will be updated with the correct value | |||
| _setMintPrice(0.01 ether); | |||
| _setMintPrice(3098470956104156); | |||
| _numberOfActivePufferValidators = 174; | |||
There was a problem hiding this comment.
Let's clean these up for merging into main.
WalidOfNow
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.