Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validator Pricer Logic #260

Merged
merged 7 commits into from
Jun 1, 2024
Merged

Validator Pricer Logic #260

merged 7 commits into from
Jun 1, 2024

Conversation

WalidOfNow
Copy link
Contributor

No description provided.

@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 23, 2024 •
edited
Loading

Validator Pricer Logic

Generated at commit: 1c9ec7183f00fea37fcc8b61dec662e9c2dc56bb

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 1
2
0
6
33
42
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

JasonVranek
JasonVranek requested changes May 27, 2024
View reviewed changes
script/SetupAccess.s.sol Show resolved Hide resolved
test/unit/ValidatorTicketPricer.t.sol Show resolved Hide resolved
@WalidOfNow WalidOfNow requested review from JasonVranek and bxmmm1 May 28, 2024 23:01
@bxmmm1
Copy link
Contributor

bxmmm1 commented May 29, 2024

We should update foundry.toml to use the latest Solidity version.

@WalidOfNow WalidOfNow requested a review from bxmmm1 May 29, 2024 23:11
@WalidOfNow WalidOfNow force-pushed the feature/validator-mint-price branch from 8d0b091 to 8dd99db Compare June 1, 2024 02:55
bxmmm1
bxmmm1 approved these changes Jun 1, 2024
View reviewed changes
script/SetupAccess.s.sol
);

bytes4[] memory paymasterSelectors = new bytes4[](3);
paymasterSelectors[0] = ValidatorTicketPricer.setDailyMevPayouts.selector;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You forgot to rename the variable.

@bxmmm1 bxmmm1 merged commit af17eaf into master Jun 1, 2024
3 of 4 checks passed
@bxmmm1 bxmmm1 deleted the feature/validator-mint-price branch June 1, 2024 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxmmm1 bxmmm1 bxmmm1 approved these changes

@JasonVranek JasonVranek Awaiting requested review from JasonVranek

Assignees

@WalidOfNow WalidOfNow

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@WalidOfNow @bxmmm1 @JasonVranek