Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timelock Fixes #80

Merged
merged 8 commits into from
May 31, 2024
Merged

Timelock Fixes #80

merged 8 commits into from
May 31, 2024

Conversation

WalidOfNow
Copy link
Contributor

No description provided.

@WalidOfNow WalidOfNow requested review from bxmmm1 and JasonVranek May 29, 2024 00:10
@bxmmm1 bxmmm1 self-requested a review May 31, 2024 10:23
@bxmmm1
Copy link
Contributor

bxmmm1 commented May 31, 2024

Some of my comments were removed because of the force-push.

We should use OZ functionCall https://github.com/OpenZeppelin/openzeppelin-contracts/blob/c1d6ad5a307945c7825cb3c4c911f2fd017c8725/contracts/utils/Address.sol#L62

Also _executeTransaction from the community multisig doesn't emit an event.

@bxmmm1 bxmmm1 merged commit 122e116 into main May 31, 2024
3 of 4 checks passed
@bxmmm1 bxmmm1 deleted the timelock-fix branch May 31, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bxmmm1 bxmmm1 bxmmm1 approved these changes

@JasonVranek JasonVranek Awaiting requested review from JasonVranek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WalidOfNow @bxmmm1