Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES module support and fixes for nodejs 18 #13

Closed
wants to merge 8 commits into from

Conversation

stefanwerfling
Copy link
Contributor

Add this patch, and you can use it for modern projects!

  • ES Module Support
  • NodeJS 18 ready
    • fix missing implementation (parameter, methods)

@PupilTong
Copy link
Owner

Please rebase your branch to run the latest ci test.

Copy link
Owner

@PupilTong PupilTong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please pass the ci test.

@@ -0,0 +1 @@
package-lock=false
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we need to keep the lock file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a lib, it should always be noticed immediately if it can no longer be built due to dependencies. So I recently found out that "compose" is missing as a method. I will keep these, otherwise I'll be in the dark and only notice these effects later in the project, when it goes into the productive system.

Of course, I can also understand the advantages.

@@ -23,7 +23,9 @@ int init(int fd, bool isTap, char* name) {
ifr.ifr_flags = IFF_TUN;
}

ifr.ifr_flags |= IFF_NO_PI;
if(disablePacketInfo)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you please add some test cases for this switch?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

give me some time, I'll take care of it

tsconfig.json Show resolved Hide resolved
@stefanwerfling
Copy link
Contributor Author

Let's discard that for now, I don't need it myself for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants