-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Alerts Fix, and adding object-store-accounts
#83
Conversation
Addess enancement #82
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs changes, and docs - i'll work on these.
|
To get this merged, I just need a new instrument and the three new metrics documented in https://github.com/PureStorage-OpenConnect/pure-fb-openmetrics-exporter/blob/main/specification/metrics/purefb-metrics.md |
internal/openmetrics-exporter/object_store_accounts_collector.go
Outdated
Show resolved
Hide resolved
I still need docs to get this merged |
I've added the docs scaffolding for now - good enough if we want to get a release in. Tested on 4.5.0 and 4.3.8 |
ready to merge once reviewed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Fixed issue #81
Address enhancement #82
closes #81
closes #82