Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alerts Fix, and adding object-store-accounts #83

Merged
merged 7 commits into from
Oct 21, 2024
Merged

Alerts Fix, and adding object-store-accounts #83

merged 7 commits into from
Oct 21, 2024

Conversation

chrroberts-pure
Copy link
Collaborator

Fixed issue #81
Address enhancement #82

closes #81
closes #82

Addess enancement #82
@chrroberts-pure chrroberts-pure added bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request metrics/in development The metric is available in a Purity API version and is in development for use within the OME. labels Aug 29, 2024
Copy link
Collaborator Author

@chrroberts-pure chrroberts-pure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs changes, and docs - i'll work on these.

build/docker/Dockerfile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
internal/rest-client/object_store_accounts.go Outdated Show resolved Hide resolved
@chrroberts-pure
Copy link
Collaborator Author

# HELP purefb_object_store_accounts_space_bytes FlashBlade object store accounts space in bytes
# TYPE purefb_object_store_accounts_space_bytes gauge
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="available_provisioned"} 0
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="destroyed"} 0
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="destroyed_virtual"} 0
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="snapshots"} 0
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="total_physical"} 80
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="total_provisioned"} 0
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="unique"} 80
purefb_object_store_accounts_space_bytes{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test",space="virtual"} 512
# HELP purefb_object_store_accounts_object_count FlashBlade object store accounts object count
# TYPE purefb_object_store_accounts_object_count gauge
purefb_object_store_accounts_object_count{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test"} 1
# HELP purefb_object_store_accounts_data_reduction_ratio FlashBlade object store accounts data reduction
# TYPE purefb_object_store_accounts_data_reduction_ratio gauge
purefb_object_store_accounts_data_reduction_ratio{id="71e66504-a6e6-4f77-a241-8b8e32a612de",name="aa-test"} 6.4

@chrroberts-pure
Copy link
Collaborator Author

To get this merged, I just need a new instrument and the three new metrics documented in https://github.com/PureStorage-OpenConnect/pure-fb-openmetrics-exporter/blob/main/specification/metrics/purefb-metrics.md

@chrroberts-pure chrroberts-pure mentioned this pull request Aug 29, 2024
5 tasks
@chrroberts-pure
Copy link
Collaborator Author

I still need docs to get this merged

@chrroberts-pure chrroberts-pure marked this pull request as ready for review October 21, 2024 17:30
@chrroberts-pure
Copy link
Collaborator Author

I've added the docs scaffolding for now - good enough if we want to get a release in.

Tested on 4.5.0 and 4.3.8

@chrroberts-pure
Copy link
Collaborator Author

ready to merge once reviewed

Copy link
Collaborator

@sdodsley sdodsley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@sdodsley sdodsley merged commit 4a0677d into main Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working documentation Improvements or additions to documentation enhancement New feature or request metrics/in development The metric is available in a Purity API version and is in development for use within the OME.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhancement: Expose Account Metrics Alert 1124 Not Parsing Correctly
3 participants