-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/3 create product category optional #6
Open
Pauloparakleto
wants to merge
22
commits into
client-branch
Choose a base branch
from
feat/3-create-product-category-optional
base: client-branch
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feat/3 create product category optional #6
Pauloparakleto
wants to merge
22
commits into
client-branch
from
feat/3-create-product-category-optional
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prepare agile philosophy.
do not validate presence of category.
category is optional.
create product, it counts by 1. category is optional.
include devise test helpers to sign_in user.
Copy database sample to database config
add username and password by environment variables.
try name when category exists, fix ajax request.
show product without category
show product without category
show product without category provide context
used with node 16.
spelling
Do not chain account and category creation in factory definition.
specify node version 16.18.1
specify node version 16.18.1
specify node version 16.18.1 and yarn
specify yarn version 1.22.19
add web puma
specify bundler version.
fix seeds since it depends on factory bot in production
fix seeds since it depends on factory bot in production and also ffaker gem
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #3