-
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes a number of Pointer related issues #774
Conversation
@davesmith00000 It's worth noting the changes here for the UI, which now uses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. One big no-no jumped out at me, will check it over again with fresh eyes.
indigo/indigo/src/main/scala/indigo/platform/events/WorldEvents.scala
Outdated
Show resolved
Hide resolved
Pointer events in JS do not have a click event - so here we generate one based on the pointer down and up events
…ancedGameConfig` Additionally adds helper method to `AdvancedGameConfig` to set the `clickTime` value.
This should fix #747
5d38926
to
948ac2e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Addresses the following issues:
pointers
toSceneContext
(SceneContext does not export the pointer instance #748)Pointers
( The Pointers class is missing convenience methods #749)PointerEvent.PointerClick
method, which is fired when aPointerDown
event is followed by aPointerUp
event for the same button within a specified, configurable, time frame (defaults to 200ms) (Have a way of discerning click events #703)Pointer
rather thanMouse
(Button's do not support Pointer events #747)