All Component functions take a full context instance #832
+229
−210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davesmith00000
force-pushed
the
issue/819/ui-component-functions-need-full-context
branch
from
21e92df to
e45d106
Compare
davesmith00000
force-pushed
the
issue/819/ui-component-functions-need-full-context
branch
from
e45d106 to
6a814f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #819
Needs further testing.
Also, there's something about how the bounds are discovered / applied. Button has it's bounds adjusted, but you still need to know to take the coords from the context object. Can there just be one place to get the full and accurate bounds?