Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more language features #57

Merged
merged 16 commits into from
Jun 14, 2024
Merged

Add more language features #57

merged 16 commits into from
Jun 14, 2024

Conversation

tomlin7
Copy link
Contributor

@tomlin7 tomlin7 commented Jan 21, 2024

Changes

Added some more language features

  • textDocument/rename
  • textDocument/foldingRange
  • textDocument/inlayHint

Akuli
Akuli reviewed Jan 22, 2024
View reviewed changes
Copy link
Collaborator

@Akuli Akuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! This looks awesome overall :) In particular, I like how you added tests, they are enough to check that the thing is working but not too detailed/noisy.

Github actions is not running for some reason. I will try to figure it out, but it could also be something that only @PurpleMyst can fix.

LICENSE Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
sansio_lsp_client/client.py Outdated Show resolved Hide resolved
sansio_lsp_client/structs.py Outdated Show resolved Hide resolved
.vscode/settings.json Outdated Show resolved Hide resolved
@PurpleMyst
Copy link
Owner

Could you update poetry.lock so that workflows can run?

@PurpleMyst
Copy link
Owner

Great, thank you! There's certainly black and mypy to fix, but I've no idea what the pytest error's about.

@Akuli
Copy link
Collaborator

Akuli commented Apr 29, 2024 •
edited
Loading

@PurpleMyst CI is finally green. Please merge if this seems good to you.

@tomlin7 Sorry that this took so long. Future pull requests (from tarts) shouldn't be as painful as this.

@tomlin7
Copy link
Contributor Author

tomlin7 commented Apr 29, 2024

@Akuli glad its good for merge now :) thanks for the hand, I'll look forward to adding more features as well!

@Moosems
Copy link

Moosems commented Jun 14, 2024

@PurpleMyst Any movement to merge?

@Akuli Akuli merged commit 212aa2d into PurpleMyst:master Jun 14, 2024
5 checks passed
Moosems referenced this pull request Jun 14, 2024
@Akuli
chore: bump version
6e08e77
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PurpleMyst PurpleMyst PurpleMyst left review comments

@Akuli Akuli Akuli left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomlin7 @PurpleMyst @Akuli @Moosems