Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spanish MVC Title Update #296, University Domains API #215, Partial Fix Issue #249 #297

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

pritam-ravani
Copy link
Contributor

@pritam-ravani pritam-ravani commented Dec 31, 2023

Summary

  1. Spanish MVC Title
    I have edited the title for MVC in the spanish version to Modelo, Vista, Controlador. The changes were made in the TWP52.rst file line 262.

262 + MVC - Modelo, Vista, Controlador

  1. University Domains API
    I have made changes in the files "TWP45_4_en.rst" and "TWP45_4.rst", by removing the proxy that was being used and now the API for universities data is being called directly.

  2. Partial Implementation of Google Log Puzzle:
    UI Implementation is done, tests, and outputs are remaining.

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

(prefer Playwright recorded video or animated gif)
Screencast from 2024-01-01 01-55-35.webm

@pritam-ravani pritam-ravani changed the title Spanish MVC Title Update TWP52.rst #296 Spanish MVC Title Update #296 and University Domains API #215 Dec 31, 2023
@pritam-ravani pritam-ravani changed the title Spanish MVC Title Update #296 and University Domains API #215 Spanish MVC Title Update #296, University Domains API #215, Partial Fix Issue #249 Jan 12, 2024
@pritam-ravani pritam-ravani requested a review from eamanu January 12, 2024 15:22
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants