Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed broken reddit api exercise #320

Merged
merged 5 commits into from
Mar 15, 2024

Conversation

abadoni5
Copy link
Contributor

@abadoni5 abadoni5 commented Mar 7, 2024

Summary

closes #289

Checklist

  • Variables, functions and comments are translated to Spanish
  • Functions follow underscore notation
  • Spell check done & typos fixed
  • All python code is PEP8 compliant
  • Test coverage with Playwright implemented; locators are Pyhton code
  • Reviewers assigned (all peers & at least 1 mentor)

Screenshots

Screenshot 2024-03-07 at 10 37 41 PM

@abadoni5
Copy link
Contributor Author

abadoni5 commented Mar 7, 2024

@NicolasSandoval the broken reddit exercise was due to the CORS proxy not working with the new reddit api, my workaround for this is calling api.reddit.com/endpoint directly since it gives no CORS error. Please give me suggestions if this approach is fine.

Copy link

github-actions bot commented Mar 7, 2024

1 similar comment
Copy link

github-actions bot commented Mar 7, 2024

Copy link

github-actions bot commented Mar 8, 2024

@NicolasSandoval
Copy link
Member

@abadoni5, looks good to me.

Please resolve the conflict with the requirements. Thank you.

Copy link

Copy link
Member

@NicolasSandoval NicolasSandoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abadoni5!

@NicolasSandoval NicolasSandoval merged commit 912c7df into PyAr:main Mar 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken Reddit Exercise [TWP 45]
2 participants