Update stage names for pre-commit
#2296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2296 +/- ##
=======================================
Coverage 99.15% 99.15%
=======================================
Files 39 39
Lines 3091 3091
Branches 748 748
=======================================
Hits 3065 3065
Misses 15 15
Partials 11 11 |
|
Could you please rebase/merge main to check if this would fix security checks |
The branch looks to be up to date with main: commit 4eeb37a is on top of the current tip of main (though the last commit on main was ~10 months ago) $ git log --max-count=2 --format='%H %s'
4eeb37a8cda544171d223c00b4729eaefd1528b6 Update stage names for `pre-commit`
7de182933fd50e04a7c47cc8be75a6547754b19c Merge pull request #2223 from PyCQA/dependabot/pip/gitpython-3.1.41 |
|
It's sad to see security check failing because of vulnerable main branch. I had a little bit of hope that this would fix failing job. |
There was a problem hiding this comment.
@timothycrosley @staticdev This PR addresses warnings that pre-commit currently throws when installing isort as a hook. I recommend merging.
|
When will this be merged and released? |
`pre-commit` v4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimum `pre-commit` version to one that supports the new names See also[2] for a similar change and the docs[3]. [1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05 [2] pre-commit/pre-commit-hooks@003dfa5 [3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages Fixes: PyCQA#2294
matthewhughes934
force-pushed
the
update-pre-commit-stages
branch
from
4eeb37a to
780f7eb
Compare
|
I juts rebased on |
|
Thanks |
pre-commitv4.0.0 added a warning to deprecated stage names[1] so update these names to avoid the warning. This also required updating the minimumpre-commitversion to one that supports the new namesSee also[2] for a similar change and the docs[3].
[1] https://github.com/pre-commit/pre-commit/blob/cc4a52241565440ce200666799eef70626457488/CHANGELOG.md#400---2024-10-05
[2] pre-commit/pre-commit-hooks@003dfa5
[3] https://pre-commit.com/#confining-hooks-to-run-at-certain-stages
Fixes: #2294