Skip to content

Commit

Permalink
Fixes #293 showing an errant space in the docs with the ``hang-closin…
Browse files Browse the repository at this point in the history
…g`` flag.
  • Loading branch information
Aleck Landgraf committed Jun 2, 2016
1 parent b02d768 commit b85fd64
Show file tree
Hide file tree
Showing 3 changed files with 26 additions and 2 deletions.
4 changes: 2 additions & 2 deletions docs/intro.rst
Original file line number Diff line number Diff line change
Expand Up @@ -405,8 +405,8 @@ This is the current list of error and warning codes:
**(*)** In the default configuration, the checks **E121**, **E123**, **E126**,
**E133**, **E226**, **E241**, **E242**, **E704** and **W503** are ignored because
they are not rules unanimously accepted, and `PEP 8`_ does not enforce them. The
check **E133** is mutually exclusive with check **E123**. Use switch ``--hang-
closing`` to report **E133** instead of **E123**.
check **E133** is mutually exclusive with check **E123**. Use switch
``--hang-closing`` to report **E133** instead of **E123**.

**(^)** These checks can be disabled at the line level using the ``# noqa``
special comment. This possibility should be reserved for special cases.
Expand Down
8 changes: 8 additions & 0 deletions testsuite/E12.py
Original file line number Diff line number Diff line change
Expand Up @@ -373,4 +373,12 @@ def example_issue254():

print(a
, end=' ')
#: E133:3:1 --hang-closing
a = [
12
]
#: Okay --hang-closing
a = [
12
]
#:
16 changes: 16 additions & 0 deletions testsuite/support.py
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,19 @@ def init_tests(pep8style):
report = pep8style.init_report(TestReport)
runner = pep8style.input_file

def set_hang_closing_option(pep8style, codes):
"""Set hang-closing option if present in the test codes.
(mutates pep8style)
Usage in test:
#: #E133:3:1 --with-hanging
"""
pep8style.options.hang_closing = '--hang-closing' in codes
codes = [c for c in codes if c != '--hang-closing']
return codes

def run_tests(filename):
"""Run all the tests from a file."""
lines = readlines(filename) + ['#:\n']
Expand All @@ -162,6 +175,9 @@ def run_tests(filename):
if codes and index:
if 'noeol' in codes:
testcase[-1] = testcase[-1].rstrip('\n')

codes = set_hang_closing_option(pep8style, codes)

codes = [c for c in codes
if c not in ('Okay', 'noeol')]
# Run the checker
Expand Down

0 comments on commit b85fd64

Please sign in to comment.