Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#345: Fix imports breaking setuptools #346

Closed
wants to merge 3 commits into from

Conversation

dargueta
Copy link
Contributor

@dargueta dargueta commented Aug 13, 2019

Type of changes

  • Bug fix
  • New feature
  • Documentation / docstrings
  • Tests
  • Other

Checklist

  • I've run the latest black with default args on new code.
  • I've updated CHANGELOG.md and CONTRIBUTORS.md where appropriate.
  • I've added tests for new code.
  • I accept that @willmcgugan may be pedantic in the code review.

Description

See detailed description in #345; this PR fixes it. I've tested this manually using fs.dropboxfs and it seems to work, but I don't know how to write unit tests for it.

@dargueta
Copy link
Contributor Author

See discussion in ticket; this may be wrong

@dargueta dargueta closed this Aug 14, 2019
@dargueta dargueta deleted the namespacing branch August 14, 2019 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant