Dockerize discoreg #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonafato
reviewed
Oct 2, 2023
Dockerfile
Outdated
| ENV PYTHONUNBUFFERED 1 | ||
|
|
||
| WORKDIR /discoreg | ||
| EXPOSE 80 |
There was a problem hiding this comment.
We'll be running this behind nginx, so can we use 8000 (or whatever gunicorn's default port is) here?
jonafato
reviewed
Oct 2, 2023
requirements.txt
Outdated
There was a problem hiding this comment.
Can we use something like pip-compile to retain the separation of top-level and fully pinned requirements? Happy to contribute this change to the PR myself, just want to make sure we don't lose that information and the ability to reasonably upgrade dependencies going forward.
jonafato
reviewed
Oct 3, 2023
discoreg/discoreg/settings.py
Outdated
There was a problem hiding this comment.
We should probably make the database configurable (e.g. with https://github.com/jazzband/dj-database-url) along with this change. In the mean time, I'll likely mount the path to the database as a docker volume to make sure it persists to disk.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First shot at dockerizing discoreg
2 containers can be created