Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

multiple contests #112

Merged
merged 1 commit into from
May 9, 2019
Merged

multiple contests #112

merged 1 commit into from
May 9, 2019

Conversation

rishabhKalakoti
Copy link
Contributor

@rishabhKalakoti rishabhKalakoti commented May 9, 2019 •
edited
Loading

  • made a basic system for multiple contests
  • made a basic UI for multiple contests
  • dummy contests to be added manually as of now
  • contest timings not covered in this PR
  • exception handler missing
  • same question set copied again to have more questions for testing

fixes #106
fixes #107

theSage21
theSage21 reviewed May 9, 2019
View reviewed changes
server.py Show resolved Hide resolved
@theSage21
Copy link
Member

This is beautiful work. 👍

Some stuff needs to be filled out. Would you like to do it as separate issues or within this PR? Here are things that come to mind:

  • reusing questions per contest is actually a good idea
  • leaderboard calculation needs to change for each contest
  • leaderboard calculation needs to only count questions which are in the contest

@rishabhKalakoti
Copy link
Contributor Author

I was planning to go like:
multiple contests > contest timings > leaderboard
one by one to keep things simpler

@theSage21 theSage21 merged commit 3d0b8ec into PyJaipur:master May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theSage21 theSage21 theSage21 approved these changes

@kirtibajaj kirtibajaj Awaiting requested review from kirtibajaj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple contest UI design Multiple contests
2 participants
@rishabhKalakoti @theSage21