Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: added .pyc to gitignore #104

Merged
merged 2 commits into from
Jun 16, 2024
Merged

minor: added .pyc to gitignore #104

merged 2 commits into from
Jun 16, 2024

Conversation

mrava87
Copy link
Contributor

@mrava87 mrava87 commented Jun 16, 2024

No description provided.

@mrava87 mrava87 requested a review from rohanbabbar04 June 16, 2024 14:40
@mrava87
Copy link
Contributor Author

mrava87 commented Jun 16, 2024

@rohanbabbar04 I made a new PR and noticed that tests failed (they run locally)... so I went ahead making a dummy PR with just a small change to the .gitignore file to see if the test failures were due to any new code, but I get the same issue here.

It is unclear to me what happens as I don't see to be able to stop the tests and understand where the error is. Do you mind taking a look as well?

@rohanbabbar04
Copy link
Collaborator

rohanbabbar04 commented Jun 16, 2024

@mrava87, I got it its because of the new version of numpy=2.0.0 which is released today and has some major changes...
We would need to make the changes accordingly to handle numpy==2.0.0.

@mrava87
Copy link
Contributor Author

mrava87 commented Jun 16, 2024

Oh wow, good catch. I knew numpy v2 was coming but didn't realize it was today.

Ok, let's go ahead with what you have done (force not to install numpy 2) and later we can revise this... we can install numpy 2 locally and try to figure out what is the problem with the Laplacian test.

Feel free to merge this PR

@rohanbabbar04 rohanbabbar04 merged commit e6b49d6 into main Jun 16, 2024
25 checks passed
@rohanbabbar04 rohanbabbar04 deleted the test-build branch September 25, 2024 03:26
rohanbabbar04 added a commit that referenced this pull request Oct 4, 2024
* minor: added .pyc to gitignore

* Update numpy in txt

---------

Co-authored-by: rohanbabbar04 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants