Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improved handling of shapes #112

Merged
merged 2 commits into from
Oct 24, 2024
Merged

feat: improved handling of shapes #112

merged 2 commits into from
Oct 24, 2024

Conversation

mrava87
Copy link
Contributor

@mrava87 mrava87 commented Oct 21, 2024

This PR improves the handling of global_shape and local_shapes in DistributedArray, allowing one to pass integers instead of tuples for 1D array:

  • For global_shape this was already allowed, but a bug has been identified when local_shapes!=None since in _check_local_shapes this is indexed - see

    if self._allreduce(local_shape[self.axis]) != self.global_shape[self.axis] or \

  • For local_shapes, this is a new feature

@mrava87
Copy link
Contributor Author

mrava87 commented Oct 22, 2024

@rohanbabbar04 just checking you saw this :)

@rohanbabbar04
Copy link
Collaborator

rohanbabbar04 commented Oct 23, 2024

@rohanbabbar04 just checking you saw this :)

Let me test this, I will get back on this tomorrow :)

@rohanbabbar04
Copy link
Collaborator

@mrava87,
It looks good to merge

@mrava87 mrava87 merged commit 57b793e into main Oct 24, 2024
25 checks passed
@mrava87 mrava87 deleted the patch-tupleshapes branch October 25, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants