Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2D-distribution #114

Merged
merged 16 commits into from
Nov 23, 2024
Merged

2D-distribution #114

merged 16 commits into from
Nov 23, 2024

Conversation

mrava87
Copy link
Contributor

@mrava87 mrava87 commented Oct 23, 2024

See #113

@mrava87 mrava87 requested a review from rohanbabbar04 October 26, 2024 19:55
@mrava87 mrava87 marked this pull request as ready for review October 26, 2024 19:55
@mrava87
Copy link
Contributor Author

mrava87 commented Oct 27, 2024

@rohanbabbar04 this could do with your review and comments 😄

@rohanbabbar04
Copy link
Collaborator

rohanbabbar04 commented Oct 29, 2024

@rohanbabbar04 this could do with your review and comments 😄

I would review this by the end of this week :)

Thank You

@rohanbabbar04
Copy link
Collaborator

Sorry,
Give me time till this week
I am onto this...

@mrava87
Copy link
Contributor Author

mrava87 commented Nov 18, 2024

Any news on this @rohanbabbar04

@rohanbabbar04
Copy link
Collaborator

rohanbabbar04 commented Nov 19, 2024

I think we should add information about the UNSAFE_BROADCAST in the Warning section of this page to inform users about it. What do you think?

@mrava87
Copy link
Contributor Author

mrava87 commented Nov 19, 2024

I agree, good point! As we already explain the BROADCAST, we can explain that to avoid that behavior one has to use UNSAFE_BROADCAST at their own risk (with more responsibility comes higher risk 😜

@mrava87 mrava87 merged commit 1351e7a into main Nov 23, 2024
59 checks passed
@mrava87 mrava87 deleted the 2ddistr branch November 23, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants