Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade maturin #9

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Upgrade maturin #9

wants to merge 6 commits into from

Conversation

mbway
Copy link
Collaborator

@mbway mbway commented Nov 17, 2024

upgrade to latest packages.

(draft: waiting on #8 )

@mbway mbway requested a review from messense November 17, 2024 16:45
@mbway mbway force-pushed the upgrade_maturin branch 3 times, most recently from 93bd51a to 0873398 Compare November 17, 2024 19:10
@mbway mbway self-assigned this Nov 17, 2024
@mbway mbway removed the request for review from messense November 17, 2024 19:44
@mbway
Copy link
Collaborator Author

mbway commented Nov 17, 2024

currently maturin new --bindings creates projects using pyo3 == 0.22.0 which is why the tests are failing because I upgraded the projects to be 0.23.1. PyO3/maturin#2308 is merged and changes to use 0.23.1 but I think this PR should wait until the next maturin release so the import hook is tied to a release tag of maturin and not a random commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@messense messense messense left review comments

Assignees

@mbway mbway

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mbway @messense