PoC for supporting uniffi bindgen with multiple crates #1910
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uniffi supports using types from dependent crates, https://mozilla.github.io/uniffi-rs/proc_macro/index.html#types-from-dependent-crates. Consider a crate
a
which depends onb
. This results in two python files being generated,a.py
andb.py
.The previous solution relied on manually building the expected bindgen filename, which worked well with just a single python output. This atlernative approach relies on finding all python files in the target directory and including them in the wheel.
At the current stage this is a fairly brute force approach which resolves my use case. I would appreciate feedback on the general approach.
Resolves #1904