Pin byteorder on msrv #3498
Merged
Pin byteorder on msrv #3498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamreichold
approved these changes
Oct 6, 2023
adamreichold
reviewed
Oct 6, 2023
|
I think to get this through CI you'll also need to resolve the new lint failure in https://github.com/PyO3/pyo3/actions/runs/6435273809/job/17476209992?pr=3487#step:7:1071 (caused by Rust 1.73 release) |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Ouch, @messense any idea what's going on in the macos failure in maturin-action? As for why the UI test is only failing on windows coverage... 🤕 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Fixed in PyO3/maturin-action#219 |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/PyO3/pyo3/actions/runs/6435273809/job/17476207748?pr=3487