Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Frame ffi functions #4881

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added Frame ffi functions #4881

wants to merge 1 commit into from

Conversation

dsal3389
Copy link

@dsal3389 dsal3389 commented Jan 29, 2025

in continuation for
#4875
#4762

adding pyframe missing ffi functions https://docs.python.org/3.13/c-api/frame.html

@dsal3389
Copy link
Author

I know I am missing documentations and more, I just wanted to make sure I am going in the right direction with my implementation before I continue to write everything

@dsal3389 dsal3389 marked this pull request as draft January 29, 2025 19:20
@ngoldbaum
Copy link
Contributor

ngoldbaum commented Jan 29, 2025

I would maybe do this in two PRs. First update the FFI definitions, then expand the rust wrappers in a second PR.

We try to keep the FFI wrappers as close to exactly matching the corresponding CPython header so please try to keep everything in the same order as the upstream header and explicitly note anything you're skipping, if you skip anything.

It also looks like you're missing some stuff for Python 3.13. I realize there were changes in this API in 3.13 that might make a little more complicated to write the FFI definitions, but we support 3.13 so we need to implement the 3.13 C API.

@dsal3389 dsal3389 marked this pull request as ready for review January 31, 2025 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants