Julia 1.5+ and JuMP 0.21+ compat #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes API changes for Julia, JuMP, CSV and DataFrames.
Minor typos and style fixes, e.g. here.
Along the way, only minor changes on the model implementation, e.g. here, and
p_nom_maxunbounded as the input CSV format in PyPSA appears to have changed in the meantime.Finally, I added the now standard
Project.tomlpackage definition file.I based this on master and only now saw the other branches
julia-v1.1-jump-v0.1x.xwith some of them having a lot of commits in them. If you want me to squash or break down the commits some more, let me know. Not sure how you want to proceed here and whether you want to create parity with PyPSA. I think it would be worthwile to have a benchmark and validation of PyPSA. I can contribute here and there, but the PyPSA code has evolved quite a bit since I last looked into it. OTOH, it might be good to have a fresh model in Julia that implements the math and is not concerned with PyPSA legacy. WDYT?