-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: overhaul ci and cd workflows #326
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 84.93% 85.95% +1.02%
==========================================
Files 17 17
Lines 4202 4202
Branches 988 988
==========================================
+ Hits 3569 3612 +43
+ Misses 474 431 -43
Partials 159 159 ☔ View full report in Codecov by Sentry. |
If you don't mind, I would just add some changes |
Of course, go ahead. |
Plesse see the output of baipp: https://github.com/PyPSA/linopy/actions/runs/9871896061/attempts/1#summary-27260815050 I think this is really helpful. |
@afuetterer CI with the baipp versions still needs a fix. |
This comment was marked as outdated.
This comment was marked as outdated.
I added concurrency to cancel early, if multiple commits are pushed in short time to the same PR. |
Okay, well, of course you needed to have python versions defined in the pyproject.toml. 😄 |
Oh my god, finally. Please squash. 😄 |
Should I squash the commits or do you perform squash and merge? Any more changes at the moment? |
I guess you need to update the required check in your PR settings. It hangs. |
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let @FabianHofmann squash and merge.
Thanks a lot for all your input @afuetterer !
Fingers crossed, that the release workflow and the trusted publishing works. |
I will test that in a release of a different repo soon |
@lkstrp let me know if we should merge this |
@FabianHofmann Let's go |
Oh no. |
ah damn forgot about that, a good reminder that we wanted to set squash as default for prs |
Good idea. |
so that everybody these sees that effort you have made ;) thanks for the nice contributions! |
Fixes #325