Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refining scenarios #35

Merged
merged 23 commits into from
Jan 25, 2025
Merged

Refining scenarios #35

merged 23 commits into from
Jan 25, 2025

Conversation

lindnemi
Copy link
Contributor

Before asking for a review for this PR make sure to complete the following checklist:

  • Workflow with target rule ariadne_all completes without errors
  • The logic of export_ariadne_variables has been adapted to the changes
  • One or several figures that validate the changes in the PR have been posted as a comment
  • A brief description of the changes has been added to Changelog.md
  • The latest main has been merged into the PR
  • The config has a new prefix of the format YYYYMMDDdescriptive_title

Copy link
Contributor

github-actions bot commented Jan 23, 2025

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • main failed in: export_ariadne_variables
  • refining-scenarios failed in: export_ariadne_variables

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing refining-scenarios (ccac88c) with main (5054f59).
Branch is 23 commits ahead and 1 commits behind.
Last updated on 2025-01-25 18:04:53 CET.

Copy link
Contributor

@toniseibold toniseibold left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The industry demand is not yet changed to match high/low demand scenario.
FT efficiency change is not working yet.
Minor changes to make sure we don't see any weird behaviour with the H2 derivative export.

scripts/prepare_sector_network.py Outdated Show resolved Hide resolved
config/config.yaml Outdated Show resolved Hide resolved
scripts/pypsa-de/modify_cost_data.py Show resolved Hide resolved
scripts/pypsa-de/additional_functionality.py Show resolved Hide resolved
scripts/pypsa-de/additional_functionality.py Show resolved Hide resolved
scripts/pypsa-de/additional_functionality.py Show resolved Hide resolved
@lindnemi lindnemi requested a review from toniseibold January 24, 2025 12:32
@lindnemi lindnemi merged commit 5054f59 into main Jan 25, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants