-
Notifications
You must be signed in to change notification settings - Fork 256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix myopic optimization for networks with geothermal district heating #1453
Conversation
Validator ReportI am the Validator. Download all artifacts here. ❗ Run failed!Download 'logs' artifact to see more details.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for spotting this! Just had minor comments.
Also, could you update the release notes and show a quick before/after comparison of COPs to make sure everything is working as expected? (e.g. a cooked-down version of the last plot in this PR: #1290 )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go when @amos-schledorn and my comments addressed.
…riable instead of string slicing
Hey @cpschau, sorry I didn't see this earlier: in your plot, it looks like the COP for 2030 build year HPs is a bit higher than the COP for 2020 build year HPs in 2030. But maybe I'm reading this wrong? |
You are reading it right. For the geothermal heat pumps there is a higher average COP, because the 2030 network comprises new urban central heat buses in Albania, Spain, Ireland, and Montenegro, as the district heating share is increasing from 0 to 0.3 (configurable). At these buses the COPs happen to be higher than the 2020 average. |
Makes sense. Thanks! |
Good to go from my side! |
Changes proposed in this Pull Request
Geothermal heat for district heating was implemented in #1359. However, it was not working for the myopic code. This PR includes two changes, that fix the issue:
build_existing_heating_distribution
.add_brownfield
. This adjustment had to be done, because some heat pumps initialized inprepare_sector_network
potentially disappear from theirlinks_t
dataframe if their efficiency equals zero (e.g. in Denmark where geothermal source temperatures can exceed district heating supply temperatures). This correction is done to account for the supply temperature dynamics in district heating and should be further adjusted as described in District heating efficiency gains applied to decentral heat pumps #1451 to depict efficiency gains for heat pumps due to technological learning.Checklist
envs/environment.yaml
.config/config.default.yaml
.doc/configtables/*.csv
.doc/data_sources.rst
.doc/release_notes.rst
is added.