Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: prioritize mamba over conda, allow passing environment target name to installation #1461

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

FabianHofmann
Copy link
Contributor

Closes # (if applicable).

Changes proposed in this Pull Request

Checklist

  • I tested my contribution locally and it works as intended.
  • Code and workflow changes are sufficiently documented.
  • Changed dependencies are added to envs/environment.yaml.
  • Changes in configuration options are added in config/config.default.yaml.
  • Changes in configuration options are documented in doc/configtables/*.csv.
  • Sources of newly added data are documented in doc/data_sources.rst.
  • A release note doc/release_notes.rst is added.

@FabianHofmann FabianHofmann requested a review from lkstrp December 19, 2024 08:11
Copy link
Contributor

github-actions bot commented Dec 19, 2024

Validator Report

I am the Validator. Download all artifacts here.
I'll be back and edit this comment for each new commit.

❗ Run failed!

Download 'logs' artifact to see more details.

  • master failed in: make_summary
  • prioritize-mamba failed in: make_summary

Model Metrics

Benchmarks Image not available Image not available Image not available

Comparing prioritize-mamba (a44e01d) with master (e25c8ff).
Branch is 3 commits ahead and 1 commits behind.
Last updated on 2024-12-19 14:51:08 CET.

@lkstrp
Copy link
Member

lkstrp commented Dec 19, 2024

Just added an option to keep conda prioritised. I couldn't find a nice way to activate the environment. It is possible (see here), but some PATHS would still be missing after activation, and we don't want to fix a shell/ os/ conda vs. mamba

@FabianHofmann
Copy link
Contributor Author

sure thing, how would I prefer conda? passing it as an argument?

@lkstrp
Copy link
Member

lkstrp commented Dec 19, 2024

export PYPSA_PREFER_CONDA=true in your .zshrc/ .bashrc

@FabianHofmann
Copy link
Contributor Author

perfect!

@FabianHofmann FabianHofmann merged commit 12d7107 into master Dec 19, 2024
12 checks passed
@FabianHofmann FabianHofmann deleted the prioritize-mamba branch December 19, 2024 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants